ENH: Get Instance Attributes #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter out methods and protected attributes
MateusStano
added
the
Enhancement
MateusStano
requested review from
GabrielBarberini,
luimot,
Gui-FernandesBR and
phmbressan
|
@GabrielBarberini @luimot A review from you guys is extra important! Please tell me if this works well with the API |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #477 +/- ##
===========================================
+ Coverage 71.05% 71.16% +0.10%
===========================================
Files 55 55
Lines 9262 9272 +10
===========================================
+ Hits 6581 6598 +17
+ Misses 2681 2674 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
phmbressan
approved these changes
Nov 22, 2023
Gui-FernandesBR
requested changes
Nov 23, 2023
Gui-FernandesBR
approved these changes
Nov 29, 2023
MateusStano
added a commit
that referenced
this pull request
Dec 2, 2023
commit 7722736 Merge: feb3299 62c8bb6 Author: MateusStano <[email protected]> Date: Sat Dec 2 11:54:10 2023 -0300 Merge pull request #494 from RocketPy-Team/tst/testing-refactor TST: solid_motor.py testing refactors commit feb3299 Merge: a9ac31c b27edc3 Author: MateusStano <[email protected]> Date: Sat Dec 2 11:46:54 2023 -0300 Merge pull request #477 from RocketPy-Team/enh/get-attributes ENH: Get Instance Attributes commit b27edc3 Author: MateusStano <[email protected]> Date: Wed Nov 29 19:01:32 2023 +0100 TST: add test commit dcdd6bd Merge: 438f4c0 191ab9f Author: MateusStano <[email protected]> Date: Wed Nov 29 18:04:31 2023 +0100 Merge remote-tracking branch 'origin/develop' into enh/get-attributes commit 438f4c0 Author: MateusStano <[email protected]> Date: Wed Nov 29 17:44:19 2023 +0100 MNT: improve warnings commit 62c8bb6 Author: Lint Action <[email protected]> Date: Wed Nov 29 03:39:29 2023 +0000 Fix code style issues with Black commit 0180755 Author: Lucas <[email protected]> Date: Wed Nov 29 00:16:45 2023 -0300 TST: Simple refactoring While studying some of the tests that were written, I made some simple changes to conftest.py, test_function.py and test_solidmotor.py. commit 04b751d Author: MateusStano <[email protected]> Date: Fri Nov 17 19:08:21 2023 +0100 BUG: fix time_array assignment in Environment class commit 1dd5e1e Author: MateusStano <[email protected]> Date: Fri Nov 17 19:08:09 2023 +0100 ENH refactor get_instance_attributes function to filter out methods and protected attributes commit 931f330 Author: MateusStano <[email protected]> Date: Fri Nov 17 16:16:09 2023 +0100 MNT: add deprecation warnings commit 2368cab Author: MateusStano <[email protected]> Date: Fri Nov 17 16:15:56 2023 +0100 ENH: add get attributes function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyDescription
This PR introduces a function to
utilities.pythat returns all relevant attributes of all main classes in RocketPy. This is a special request for the development of the Infinity-API.I have also added a deprecation warning to the old
info_returnedmethods, since they do not need to be used anymoreBreaking change
Additional information
There a couple of fixes here to the
Environment.time_arrayattribute. In some atmospheric models, this was not being saved as an array, but instead as a NetCDF4 object. This attribute is not used anywhere in the code, but it was breaking theget_instance_attributesfunction